Skip to content

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented Feb 25, 2025

Eppo Internal
[//]: # (Link to the issue or doc corresponding to this chunk of work)
🎟️ fixes FF-4060
🧵 slack

Motivation and Context

We are renaming instances of API Key to SDK Key for

  1. consistency and;
  2. to differentiate from the API keys used to connect to the Eppo API.

Description

  • Since API Key is required, move it from a builder method to the constructor
  • To keep constructors private, the builder is created from a static method on EppoClient

How has this been documented?

FF-4061

How has this been tested?

  • no functional changes, only facade

@typotter typotter requested review from felipecsl and aarsilv and removed request for felipecsl February 25, 2025 15:36
Copy link
Collaborator

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The other changes were in that other PR

Copy link
Contributor

@felipecsl felipecsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! long time coming

@typotter
Copy link
Collaborator Author

Looks good!

The other changes were in that other PR

GH automatically changed the base branch when I merged the other, but I hadn't rebased this one yet. Thanks for noting.

@typotter typotter merged commit c956b3d into main Feb 25, 2025
4 checks passed
@typotter typotter deleted the typo/ff-4060-java-sdk-rename-apikey-sdkkey branch February 25, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants